refactor(repo): внедрение универсального интерфейса Repository и упрощение работы с моделью задач (close #46) #55

Merged
KamaSK merged 1 commits from feature/generic-repository into dev 2025-06-06 19:31:57 +03:00
5 changed files with 28 additions and 29 deletions

View File

@ -4,7 +4,6 @@ import java.util.List;
import java.util.Optional;
import ru.kamask.pet.todo.model.SimpleTask;
import ru.kamask.pet.todo.model.Task;
import ru.kamask.pet.todo.service.TaskService;
public class ListCommand implements Command {
@ -28,7 +27,7 @@ public class ListCommand implements Command {
return String.format(templateUsage, name(), "Список всех задач.");
}
String formatWithTable(List<Task> tasks, String msgIfEmpty) {
String formatWithTable(List<SimpleTask> tasks, String msgIfEmpty) {
String template = "%-2s | %-30s | %s\n";
var res = new StringBuilder(String.format(template, "ID", "Название задачи", "Статус"));
res.append("-".repeat(50) + "\n");
@ -36,8 +35,8 @@ public class ListCommand implements Command {
if (tasks.size() == 0)
return res.append("\n" + msgIfEmpty).toString();
for (Task task : tasks) {
SimpleTask.Data data = ((SimpleTask) task).data();
for (SimpleTask task : tasks) {
SimpleTask.Data data = task.data();
res.append(String.format(template, data.id(), data.title(), data.done() ? "выполнено" : "не выполнено"));
}

View File

@ -6,23 +6,23 @@ import java.util.List;
import java.util.Map;
import java.util.Optional;
import ru.kamask.pet.todo.model.Task;
import ru.kamask.pet.todo.model.SimpleTask;
public class InMemoryTaskRepository implements TaskRepository {
private Map<Integer, Task> storage = new HashMap<>();
private Map<Integer, SimpleTask> storage = new HashMap<>();
@Override
public void save(Task task) {
public void save(SimpleTask task) {
storage.put(task.id(), task);
}
@Override
public Optional<Task> findById(int id) {
public Optional<SimpleTask> findById(int id) {
return Optional.ofNullable(storage.get(id));
}
@Override
public List<Task> findAll() {
public List<SimpleTask> findAll() {
return new ArrayList<>(storage.values());
}

View File

@ -0,0 +1,14 @@
package ru.kamask.pet.todo.repo;
import java.util.List;
import java.util.Optional;
import ru.kamask.pet.todo.model.Identifiable;
public interface Repository<T extends Identifiable> {
void save(T obj);
Optional<T> findById(int id);
List<T> findAll();
void delete(int id);
boolean has(int id);
}

View File

@ -1,18 +1,5 @@
package ru.kamask.pet.todo.repo;
import java.util.List;
import java.util.Optional;
import ru.kamask.pet.todo.model.SimpleTask;
import ru.kamask.pet.todo.model.Task;
public interface TaskRepository {
void save(Task task);
Optional<Task> findById(int id);
List<Task> findAll();
void delete(int id);
boolean has(int id);
}
public interface TaskRepository extends Repository<SimpleTask> {}

View File

@ -3,7 +3,6 @@ package ru.kamask.pet.todo.service;
import java.util.List;
import java.util.Optional;
import ru.kamask.pet.todo.model.Task;
import ru.kamask.pet.todo.model.SimpleTask;
import ru.kamask.pet.todo.repo.TaskRepository;
@ -18,7 +17,7 @@ public class TaskService {
repo.save(new SimpleTask(title));
}
public Optional<Task> getById(int id) {
public Optional<SimpleTask> getById(int id) {
return repo.findById(id);
}
@ -31,7 +30,7 @@ public class TaskService {
return false;
}
public List<Task> list() {
public List<SimpleTask> list() {
return repo.findAll();
}
@ -43,9 +42,9 @@ public class TaskService {
return repo.has(id);
}
public List<Task> search(String query) {
public List<SimpleTask> search(String query) {
return repo.findAll().stream()
.filter(task -> ((SimpleTask) task).data().title().contains(query))
.filter(task -> task.data().title().contains(query))
.toList();
}
}